Use our own unit conversion function in our fixes #2560
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2560 +/- ##
==========================================
+ Coverage 94.77% 94.79% +0.02%
==========================================
Files 251 251
Lines 14266 14280 +14
==========================================
+ Hits 13520 13537 +17
+ Misses 746 743 -3 ☔ View full report in Codecov by Sentry. |
11 tasks
valeriupredoi
requested changes
Oct 18, 2024
valeriupredoi
approved these changes
Oct 18, 2024
|
@ESMValGroup/technical-lead-development-team could one of yous please have a last look at this then merge? 🍺 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
While performing tests for ESMValGroup/ESMValTool#3784, I noticed that our fixes do not use our own unit conversion function, which allows special unit conversions like m -> DU.
This PR adds this, but uses a "safe" version of the unit conversion which will not allow a change of the cube's
standard_name(this would lead to errors in the subsequent CMOR checks).Note: I had to restructure the functions a little bit to avoid circular imports.
Related to
DUto recipes that usetozESMValTool#3784toz) more flexible and add derivation of stratospheric and tropospheric column ozone #2509Link to documentation:
Before you get started
Checklist
It is the responsibility of the author to make sure the pull request is ready to review. The icons indicate whether the item will be subject to the 🛠 Technical or 🧪 Scientific review.
To help with the number pull requests: